symm: Handle GCM NIDs properly #468
Merged
+100
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/fun-with-nids
branch
2 times, most recently
from
20d2309 to
8eac919
Compare
cjpatton
changed the title
This method returns `None` for the GCM NIDs. It appears to be implemented incorrectly: It first calls `OBJ_nid2sn(nid)` to get the NID's short name, then calls `EVP_get_cipherbyname(name)`. The documentation isn't clear as to whether `name` should be the short or long name, but it appears to expect the long name. At least, changing to `OBJ_nid2sn()` to `OBJ_nid2ln()` makes the method work properly, To fix this, this commit calls `EVP_get_cipherbynid()`, which is is more direct. Note that the method still returns `None` on the 3DES NID, but we're not likely to encounter this one in practice.
cjpatton
force-pushed
the
cjpatton/fun-with-nids
branch
from
8eac919 to
0847d31
Compare
kornelski
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits in this PR. The first adds regression tests to make sure the raw NIDs don't change. The second one changes the implementation of
Cipher::from_nid()so that it properly handles the GCM ciphers. Note that the 3DES is still not handled correctly.