Add EVP_AEAD-based detached AEAD module#486
Merged
kornelski merged 1 commit intocloudflare:masterfrom Apr 16, 2026
Merged
Conversation
kornelski
reviewed
Apr 14, 2026
kornelski
reviewed
Apr 14, 2026
Introduce a new boring::aead module with Algorithm and AeadCtx wrappers over BoringSSL EVP_AEAD APIs, including detached seal_scatter/open_gather operations and seal_in_place/open_in_place convenience methods. seal_scatter returns a sub-slice of the output tag buffer rather than a raw length, so callers can use it directly without manual slicing. Add AeadCtx::new_default_tag for the common case of using the full tag length, and AeadCtxRef::tag_len for precise buffer sizing via EVP_AEAD_CTX_tag_len. Add tests for AES-GCM and XChaCha20-Poly1305 round trips, scatter/gather with extra input, invalid key/nonce/tag rejection, and tag_len; export the module from boring/src/lib.rs.
kornelski
approved these changes
Apr 15, 2026
kornelski
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new boring::aead module with Algorithm, AeadCtx, and Crypter wrappers over BoringSSL EVP_AEAD APIs, including detached seal_scatter/open_gather operations.
Document usage with module guidance, a basic detached-tag example, and an advanced scatter/gather example that explains extra_in layout and decryption handling.
Add validation and tests for key, nonce, and tag constraints, AES-GCM and XChaCha20-Poly1305 round trips, and scatter/gather with extra input; export the module from boring/src/lib.rs.