Fix mod_final_25519 #129
Merged
Fix mod_final_25519 #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bren2010
suggested changes
Apr 20, 2020
src/crypto/x25519/mod.rs
Outdated
| } | ||
|
|
||
| fn mod_final_25519(x: Felem) -> Felem { | ||
| const MASK_64BITS: u128 = 0xffff_ffff_ffff_ffff; |
There was a problem hiding this comment.
Defining this as a const at the top and replacing all instances would definitely be welcome, along with 0x7fff_....
src/crypto/x25519/mod.rs
Outdated
| acc1 = acc1.wrapping_add(acc0 >> 64); | ||
| acc2 = acc2.wrapping_add(acc1 >> 64); | ||
| acc3 = acc3.wrapping_add(acc2 >> 64); | ||
| acc3 &= 0x7fff_ffff_ffff_ffff; |
There was a problem hiding this comment.
What is this extra code doing? It doesn't make sense to me
Contributor
There was a problem hiding this comment.
Looks like masking the top bit of the output. However is it not sufficient to execute just a single extra round of mul + add?
Contributor
Author
There was a problem hiding this comment.
I put the comments in the source code. What do you think?
ppopth
force-pushed
the
fix_curve25519
branch
2 times, most recently
from
551c60b to
699367b
Compare
vkrasnov
approved these changes
Oct 29, 2020
Bren2010
suggested changes
Oct 30, 2020
src/crypto/x25519/tests.rs
Outdated
| mod tests { | ||
| use super::super::{mod_final_25519, mod_inv_25519, x25519_shared_key, Felem}; | ||
| use super::super::{ | ||
| mod_25519, mod_final_25519, mod_inv_25519, x25519_shared_key, Felem, Felem2, |
| assert_eq!(mod_final_25519(max + one).0, zero.0); | ||
| } | ||
|
|
||
| fn x25519_test_vectors() { |
There was a problem hiding this comment.
You've stolen this function's #[test] annotation
ppopth
force-pushed
the
fix_curve25519
branch
from
699367b to
fe70fbf
Compare
ppopth
force-pushed
the
fix_curve25519
branch
from
fe70fbf to
89d0276
Compare
Bren2010
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.