scan: check for revocation in PKI ChainValidation #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
scan/pki.go
Outdated
Contributor
There was a problem hiding this comment.
Style nitpicks: this should be a complete sentence. It would also be useful to explain why it might be redundant and why it's been kept in (even if the answer is just that the comment serves as a marker to go back and look at the code later).
Author
There was a problem hiding this comment.
I didn't dive deep into all the checks x509#Certificate.VerifyHostname is doing, but I think cfssl/revoke#VerifyCertificate is covers a superset of them (obviously adding CRL and OCSP revocation checks).
I think it's probably best to just remove this "quick-fail" method, as it will give less descriptive errors.
Contributor
|
One nit about a comment, other than that LGTM. |
0xhaven
force-pushed
the
jacob/scan-pki-revocation
branch
from
32afbc3 to
f4a1e87
Compare
kisom
added a commit
that referenced
this pull request
May 26, 2015
scan: check for revocation in PKI ChainValidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for use in a "Strict SSL"-compatibility checker. (CFSSL-149)