Changes to SHAKE in preparation for Dilithium support#86
Merged
bwesterb merged 1 commit intocloudflare:masterfrom Feb 13, 2020
Merged
Changes to SHAKE in preparation for Dilithium support#86bwesterb merged 1 commit intocloudflare:masterfrom
bwesterb merged 1 commit intocloudflare:masterfrom
Conversation
1. (Re)add support for SHAKE-256. 2. Reduce allocations. The byte-slice in the shake State struct confused Go's escape analysis and forced it onto the Heap. 3. Move out of dh/sidh as it will be used by sign/dilithium.
armfazh
approved these changes
Feb 12, 2020
Contributor
armfazh
left a comment
armfazh
left a comment
There was a problem hiding this comment.
Agree on moving shake package.
I think it is valuable to have your changes on shake internals in the go upstream version.
Member
Author
|
Ok, will prepare a PR later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confused Go's escape analysis and forced it onto the Heap.