-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Mounted assets docs #18657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mounted assets docs #18657
Conversation
Deploying cloudflare-docs with
|
| Latest commit: |
b88b6e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7da55866.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://walshy-mounted-assets.cloudflare-docs-7ou.pages.dev |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting that this is something that also wasn't possible with Pages - right?
I can have a custom domain with a Pages project.
But I can't define a route to say — run the Pages project at /blog.
And so here, I can just run the Worker, and its assets at /blog — that was already possible.
But before — if I had /blog directory, and ran the Worker on the /blog route, to access /dist/blog/index.html I would have to go to example.com/blog/blog
And now just example.com/blog
Is that accurate before/after?
|
Or did we just disallow mounting assets on a route before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
fc45612 to
50612e7
Compare
50612e7 to
b88b6e0
Compare
korinne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks so much!
Summary
Documents mounting assets on a given path and the behaviour of it.
Note: Waiting on Wrangler to go out
Screenshots (optional)
Documentation checklist