Documentation for HTTPS#29466
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
gabivlj
force-pushed
the
gv/tls
branch
2 times, most recently
from
ea13773 to
55b9507
Compare
mikenomitch
requested review from
a team,
Oxyjun,
elithrar,
ghostwriternr,
joshthoward,
lambrospetrou,
mikenomitch,
th0m,
vy-ton and
whoiskatrin
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| The container calls `http://my.kv/some-key` and the outbound handler resolves it using the KV binding. | ||
| This is especially useful for agentic workloads where you cannot fully trust the code running inside the container. With this pattern: | ||
|
|
||
| - **No token is exposed to the container.** The secret lives in the Worker's environment and is never passed into the sandbox. |
There was a problem hiding this comment.
🟡 Copy-paste error: containers page references "sandbox" instead of "container"
On the containers outbound-traffic page, line 153 says "never passed into the sandbox" but this is the containers page — it should say "never passed into the container." The sandbox equivalent at src/content/docs/sandbox/guides/outbound-traffic.mdx:172 correctly uses "sandbox" throughout, confirming this is a copy-paste error.
| - **No token is exposed to the container.** The secret lives in the Worker's environment and is never passed into the sandbox. | |
| - **No token is exposed to the container.** The secret lives in the Worker's environment and is never passed into the container. |
Was this helpful? React with 👍 or 👎 to provide feedback.
|
|
||
| // Remove access once setup is complete | ||
| await container.removeOutboundByHost("my.kv"); | ||
| // do something with github.com on your container... |
There was a problem hiding this comment.
🟡 Mixed tab/space indentation in code block
Line 336 uses a tab character for indentation (\t// do something with github.com...) while every other indented line in the same code block (lines 330–345) uses 2-space indentation. This renders as visibly inconsistent indentation in the documentation code example.
| // do something with github.com on your container... | |
| // do something with github.com on your container... |
Was this helpful? React with 👍 or 👎 to provide feedback.
* Documentation for HTTPS * Structural changes, allow/deny change, sandboxes added * Pass adjusted from docs/egress.md in container class and add interceptOutboundHttps * Improved docs on egress handling --------- Co-authored-by: Mike Nomitch <mnomitch@cloudflare.com>
5 participants
Summary
Screenshots (optional)
Documentation checklist