Skip to content

[Chore] Remove unused components / features from docs#30880

Merged
kodster28 merged 1 commit into
productionfrom
code-cleanup
May 18, 2026
Merged

[Chore] Remove unused components / features from docs#30880
kodster28 merged 1 commit into
productionfrom
code-cleanup

Conversation

@kodster28
Copy link
Copy Markdown
Collaborator

Remove the unusued component Checkbox, as well as unused functionality introduced by Dismissable.tsx.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.astro @cloudflare/content-engineering, @kodster28
/src/components/ @cloudflare/content-engineering, @kodster28
*.ts @cloudflare/content-engineering, @kodster28
/src/content/docs/style-guide/ @dcpena, @caley-b, @cloudflare/product-owners

@ask-bonk ask-bonk Bot added engineering Problems or updates to developers.cloudflare.com website documentation Documentation edits labels May 18, 2026
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue needs fixing before merge.

HIGHsrc/components/overrides/Banner.astro line 33: The class="min-w-[1.333em]" attribute was accidentally removed from the <Icon> component when the dismissible branch was deleted. This is a visual regression — the icon will no longer maintain its minimum width in flex layouts.

LOW — PR description has typos: "unusued" should be "unused", and "Dismissable" should be "Dismissible" (matching the filename).

Otherwise, the deletions are clean: no remaining references to Checkbox, Dismissible, or dismissible frontmatter property exist in the codebase. Type-check, lint, and format checks all pass.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 18, 2026

Suggested fix for src/components/overrides/Banner.astro line 33:

				{icon && <Icon name={icon} size="1.333em" class="min-w-[1.333em]" />}

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 18, 2026

I reviewed PR #30880 and applied the labels engineering and documentation.

Summary of changes:
The PR removes two unused pieces of code from the docs site:

  1. Checkbox.astro — a custom web component that rendered checkboxes with localStorage persistence.
  2. Dismissible.tsx — React hooks/components for dismissible UI elements (used by banner).

It also cleanly removes the associated banner dismissible logic from Banner.astro, removes the export from the components barrel file, updates the style guide docs to remove the dismissible section, and removes the dismissible property from the Zod schema.

Issues flagged:

HIGHsrc/components/overrides/Banner.astro line 33: When the dismissible branch was deleted, the class="min-w-[1.333em]" attribute was accidentally dropped from the <Icon> component. This is a visual regression. I posted the exact one-line fix in a comment.

LOW — PR description has typos: "unusued" should be "unused" and "Dismissable" should be "Dismissible".

Validation:

  • pnpm run check — passed (0 errors)
  • pnpm run lint — passed
  • pnpm run format:core:check — passed
  • No remaining references to Checkbox, Dismissible, or dismissible frontmatter in the codebase.

github run

@github-actions
Copy link
Copy Markdown
Contributor

@kodster28 kodster28 merged commit d385b2c into production May 18, 2026
21 checks passed
@kodster28 kodster28 deleted the code-cleanup branch May 18, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation edits engineering Problems or updates to developers.cloudflare.com website product:style-guide size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants