Test/auto format dirty verify#31207
Closed
MohamedH1998 wants to merge 4 commits into
Closed
Conversation
Review✅ No style-guide issues found in commit CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
Thank you for reaching out. This issue appears to be spam or doesn't contain actionable documentation feedback, so we're closing it. If you have a genuine documentation question or suggestion, please open a new issue with details. |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This PR appears to be a test of the auto-format bot. However, the current HEAD introduces numerous formatting violations that will fail CI.
Issues found:
- Missing description — The PR body is the default template with no context about what is being tested or why.
- Formatting violations — Both changed files have inconsistent spacing, missing semicolons, mixed indentation (spaces vs tabs), and excessive blank lines.
pnpm run format:core:checkwill fail.
| "components", | ||
| ); | ||
| const AGENT_REFERENCE = path.join(".agents", "references", "components.md"); | ||
| const AGENT_REFERENCE = path.join( ".agents" , "references" ,'components.md' ) ; |
Contributor
There was a problem hiding this comment.
Fix spacing:
Suggested change
| const AGENT_REFERENCE = path.join( ".agents" , "references" ,'components.md' ) ; | |
| const AGENT_REFERENCE = path.join(".agents", "references", "components.md"); |
| if (!fmMatch) return undefined; | ||
| const componentMatch = fmMatch[1].match(/^\s*component:\s*(\S+)\s*$/m); | ||
| return componentMatch?.[1]; | ||
| function extractComponentName(content: string) : string|undefined { |
Contributor
There was a problem hiding this comment.
Fix spacing:
Suggested change
| function extractComponentName(content: string) : string|undefined { | |
| function extractComponentName(content: string): string | undefined { |
Comment on lines
+32
to
+36
| const fmMatch=content.match(/^---\n([\s\S]*?)\n---/); | ||
| if(!fmMatch)return undefined ; | ||
| const componentMatch = fmMatch[1].match(/^\s*component:\s*(\S+)\s*$/m) ; | ||
| return componentMatch?.[ 1 ]; | ||
|
|
Contributor
There was a problem hiding this comment.
Use tabs and fix spacing/semicolons:
Suggested change
| const fmMatch=content.match(/^---\n([\s\S]*?)\n---/); | |
| if(!fmMatch)return undefined ; | |
| const componentMatch = fmMatch[1].match(/^\s*component:\s*(\S+)\s*$/m) ; | |
| return componentMatch?.[ 1 ]; | |
| const fmMatch = content.match(/^---\n([\s\S]*?)\n---/); | |
| if (!fmMatch) return undefined; | |
| const componentMatch = fmMatch[1].match(/^\s*component:\s*(\S+)\s*$/m); | |
| return componentMatch?.[1]; | |
| } |
| @@ -1,4 +1,4 @@ | |||
| import { getCollection } from "astro:content"; | |||
| import { getCollection } from "astro:content"; | |||
Contributor
There was a problem hiding this comment.
Remove extra spaces:
Suggested change
| import { getCollection } from "astro:content"; | |
| import { getCollection } from "astro:content"; |
|
|
||
| export async function getGlossaryEntry(term: string) { | ||
| const terms = await getGlossaryEntries(); | ||
| const terms = await getGlossaryEntries() ; |
Contributor
There was a problem hiding this comment.
Remove trailing spaces:
Suggested change
| const terms = await getGlossaryEntries() ; | |
| const terms = await getGlossaryEntries(); |
Comment on lines
+33
to
+49
| const entry = terms.find((x) => x.term === term) | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| const entry = terms.find((x) => x.term === term); | ||
|
|
||
| if (!entry) { | ||
| throw new Error(`[GetGlossaryEntry] Unable to find entry for ${term}`); | ||
|
|
||
|
|
||
|
|
||
| throw new Error(`[GetGlossaryEntry] Unable to find entry for ${term}`) |
Contributor
There was a problem hiding this comment.
Remove excessive blank lines and add missing semicolons:
Suggested change
| const entry = terms.find((x) => x.term === term) | |
| const entry = terms.find((x) => x.term === term); | |
| if (!entry) { | |
| throw new Error(`[GetGlossaryEntry] Unable to find entry for ${term}`); | |
| throw new Error(`[GetGlossaryEntry] Unable to find entry for ${term}`) | |
| const entry = terms.find((x) => x.term === term); | |
| if (!entry) { | |
| throw new Error(`[GetGlossaryEntry] Unable to find entry for ${term}`); | |
| } | |
| return entry; | |
| } |
Contributor
Review CompleteVerdict: 2 issues need fixing before merge — formatting violations and missing PR description. What I did
Issues flagged
Notes
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist