[R2 SQL] Add support for UNION, INTERSECT, EXCEPT, and SELECT DISTINCT#31252
[R2 SQL] Add support for UNION, INTERSECT, EXCEPT, and SELECT DISTINCT#31252sejoker wants to merge 1 commit into
Conversation
Review
Warnings (5)
Suggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
CI run failed: build logs |
There was a problem hiding this comment.
The documentation changes are accurate and well-structured. One issue needs attention before merge:
MEDIUM — The PR description is empty. The Summary and Screenshots sections in the body template are blank. Add a brief description of what changed and why.
|
I reviewed PR #31252 and posted a review comment on the PR. Summary of changesThe PR adds documentation for four newly supported R2 SQL features across three files:
Issues flaggedMEDIUM — The PR description is empty. The body contains only unchecked template sections (Summary, Screenshots) with no actual context about the change. I suggested adding a brief description of what changed and why before merging. Notes
One minor inconsistency I noted: the top-level query syntax block in the SQL reference still shows |
|
The 5 angle bracket warnings are false positives - all the > characters are inside SQL code blocks ( ``sql ... ``` `), |
There was a problem hiding this comment.
Two headings use title case instead of sentence case. Inline suggestions posted.
There is a failing CI run that should be investigated before merging. The bot's angle-bracket warnings appear to be false positives (all > occurrences are inside fenced sql code blocks), so the actual CI error is likely unrelated.
| SELECT zone_id FROM my_namespace.compaction_history | ||
| ``` | ||
|
|
||
| ## SELECT DISTINCT |
There was a problem hiding this comment.
Use sentence case per the style guide:
| ## SELECT DISTINCT | |
| ## Select distinct |
| - **Column alias**: `column_name AS alias` | ||
| - **Expressions**: arithmetic, function calls, CASE expressions, and casts | ||
|
|
||
| ### SELECT DISTINCT |
There was a problem hiding this comment.
Use sentence case per the style guide:
| ### SELECT DISTINCT | |
| ### Select distinct |
|
Review completed for PR #31252 Labels applied: What the PR changes
Issues flagged
Everything else checks out: Frontmatter is valid, links are root-relative with trailing slashes, code blocks use lowercase |
Summary
Add support for UNION, INTERSECT, EXCEPT, and SELECT DISTINCT in R2 SQL.
Documentation checklist