logpush: Handle invalid destination configuration#500
Merged
patryk merged 1 commit intocloudflare:masterfrom Jul 8, 2020
Merged
logpush: Handle invalid destination configuration#500patryk merged 1 commit intocloudflare:masterfrom
patryk merged 1 commit intocloudflare:masterfrom
Conversation
In the event that the destination configuration of a logpush job challenge returns an erorr, we don't currently catch that. Instead, we return the ownership challenge struct successfully which is slightly misleading. This introduces more error checking on the API itself to inspect the response payload for the `valid` parameter being set to true which handles the scenarios where ownership validation fails. Fixes cloudflare#499
patryk
approved these changes
Jul 8, 2020
Justin-Holmes
pushed a commit
to Justin-Holmes/cloudflare-go
that referenced
this pull request
Sep 17, 2020
In the event that the destination configuration of a logpush job challenge returns an erorr, we don't currently catch that. Instead, we return the ownership challenge struct successfully which is slightly misleading. This introduces more error checking on the API itself to inspect the response payload for the `valid` parameter being set to true which handles the scenarios where ownership validation fails. Fixes cloudflare#499
Justin-Holmes
pushed a commit
to Justin-Holmes/cloudflare-go
that referenced
this pull request
Sep 18, 2020
In the event that the destination configuration of a logpush job challenge returns an erorr, we don't currently catch that. Instead, we return the ownership challenge struct successfully which is slightly misleading. This introduces more error checking on the API itself to inspect the response payload for the `valid` parameter being set to true which handles the scenarios where ownership validation fails. Fixes cloudflare#499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event that the destination configuration of a logpush job
challenge returns an erorr, we don't currently catch that. Instead, we
return the ownership challenge struct successfully which is slightly
misleading.
This introduces more error checking on the API itself to inspect the
response payload for the
validparameter being set to true whichhandles the scenarios where ownership validation fails.
Fixes #499