Add support for TLS certificate packs#508
Merged
patryk merged 2 commits intocloudflare:masterfrom Jul 30, 2020
Merged
Conversation
Updates the library to introduce support for certificate packs. API documentation: - https://api.cloudflare.com/#certificate-packs-properties - https://developers.cloudflare.com/ssl/advanced-certificate-manager
jacobbednarz
force-pushed
the
add-certificate-pack-support
branch
from
26db9b2 to
93125f7
Compare
patryk
approved these changes
Jul 30, 2020
Justin-Holmes
pushed a commit
to Justin-Holmes/cloudflare-go
that referenced
this pull request
Sep 17, 2020
* Add support for TLS certificate packs Updates the library to introduce support for certificate packs. API documentation: - https://api.cloudflare.com/#certificate-packs-properties - https://developers.cloudflare.com/ssl/advanced-certificate-manager * simplify response structs Co-authored-by: Patryk Szczygłowski <patryk@patryk.net>
Justin-Holmes
pushed a commit
to Justin-Holmes/cloudflare-go
that referenced
this pull request
Sep 18, 2020
* Add support for TLS certificate packs Updates the library to introduce support for certificate packs. API documentation: - https://api.cloudflare.com/#certificate-packs-properties - https://developers.cloudflare.com/ssl/advanced-certificate-manager * simplify response structs Co-authored-by: Patryk Szczygłowski <patryk@patryk.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the library to introduce support for certificate packs.
API documentation:
This includes the support for advanced certificate management in it's
own methods. I attempted to look at combining them into a single method
and toggling functionality based on
CertificatePack.Typehowever asthe responses differed, the function signature wasn't able to be shared
between the two. In uses of the library (like Terraform provider) this
detail can be hidden behind the implementation without any hassles.