fix: Set context for requests properly#526
Merged
patryk merged 2 commits intocloudflare:masterfrom Sep 29, 2020
Merged
Conversation
`WithContext` does not mutate the request, and the returned `Request` value is ignored, so context for requests is never actually being set.
28574ee to
3ed8614
Compare
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WithContextdoes not mutate the request, and the returnedRequestvalue is ignored, so context for requests is never actually being set.Has your change been tested?
A regression test was added that ensure the context is properly passed. It failed prior to changes to the implementation.
Types of changes
What sort of change does your code introduce/modify?
Checklist: