Skip to content

feature: support DNSSEC updates#545

Merged
patryk merged 1 commit intocloudflare:masterfrom
frezbo:feature/dnssec-support
Oct 27, 2020
Merged

feature: support DNSSEC updates#545
patryk merged 1 commit intocloudflare:masterfrom
frezbo:feature/dnssec-support

Conversation

@frezbo
Copy link
Copy Markdown

@frezbo frezbo commented Oct 26, 2020

Signed-off-by: Noel Georgi git@frezbo.com

Feature: Support Zone DNSSEC updates

Description

This is the first step in providing support for DNSSEC updates in the Terraform CloudFlare provider

Has your change been tested?

Unit Tests added

Types of changes

What sort of change does your code introduce/modify?

  • [ x ] New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have added tests to cover my changes.
  • [ x ] All new and existing tests passed.

Signed-off-by: Noel Georgi <git@frezbo.com>
Copy link
Copy Markdown
Contributor

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 thanks!

@patryk
Copy link
Copy Markdown

patryk commented Oct 27, 2020

Thanks, @frezbo!

@patryk patryk merged commit 18fc232 into cloudflare:master Oct 27, 2020
@frezbo frezbo deleted the feature/dnssec-support branch October 27, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants