always marshal CustomHostnameSSL.Wildcard into api request body payload

[nicktate]

Description

When the CustomHostnameSSL field is converted to a json payload for the http request body, the Wildcard value is stripped when set to false.

Has your change been tested?

• I tested updating a custom hostname wildcard from true to false with my branch and the update succeeded
• The modified tests also succeeded via go test .

Types of changes

What sort of change does your code introduce/modify?

• Breaking change (fix or feature that would cause existing functionality to change)

Previously omitting the Wildcard key from the CustomHostname struct would effectively execute a partial update and omit the update of the wildcard field. Custom hostname updates will now always set the wildcard to the value of the passed in struct (whether or not explicitly referenced).

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jacobbednarz]

I think we may need a similar approach to #595 whereby we use a boolean pointer and explicitly set the value when it is expected. IIRC, this puts tools like Terraform in a bad position to handle changes as is.

As this is breaking change (and we've just cut 0.14 which was also breaking) we will need to wait for another breaking release to handle this one.

[nicktate]

I think we may need a similar approach to #595 whereby we use a boolean pointer and explicitly set the value when it is expected. IIRC, this puts tools like Terraform in a bad position to handle changes as is.

As this is breaking change (and we've just cut 0.14 which was also breaking) we will need to wait for another breaking release to handle this one.

Updated for a *bool -- good callout on the terraform implications

[jacobbednarz]

Thanks for this @nicktate. I suspect this will be going out in our next release as 0.15.