Skip to content

Added id, issuer, and serial_number to CustomHostnameSSL#607

Merged
jacobbednarz merged 3 commits intocloudflare:masterfrom
thienson-ho:add-ssl-fields
Mar 10, 2021
Merged

Added id, issuer, and serial_number to CustomHostnameSSL#607
jacobbednarz merged 3 commits intocloudflare:masterfrom
thienson-ho:add-ssl-fields

Conversation

@thienson-ho
Copy link
Copy Markdown

@thienson-ho thienson-ho commented Mar 9, 2021

Adding additional SSL fields returned from the "List Custom Hostnames" Cloudflare response: id, issuer, and serial_number

Description

The three fields are added based on the response returned from the below documentation.
https://api.cloudflare.com/#custom-hostname-for-a-zone-list-custom-hostnames

Has your change been tested?

Updated unit tests to reflect changes.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thienson-ho thienson-ho marked this pull request as draft March 9, 2021 17:15
@thienson-ho thienson-ho changed the title Added id, issuer, and serial_number to CustomHostnameSSL. Updated lis… Added id, issuer, and serial_number to CustomHostnameSSL Mar 9, 2021
@thienson-ho thienson-ho marked this pull request as ready for review March 9, 2021 20:12
@jacobbednarz jacobbednarz merged commit 1dd2d1f into cloudflare:master Mar 10, 2021
@jacobbednarz
Copy link
Copy Markdown
Contributor

thank you @thienson-ho! 🍭

@thienson-ho thienson-ho deleted the add-ssl-fields branch March 10, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants