AS-7353: Add cloudflare-go integration for alert history API#735
Merged
jacobbednarz merged 2 commits intocloudflare:masterfrom Nov 3, 2021
Merged
AS-7353: Add cloudflare-go integration for alert history API#735jacobbednarz merged 2 commits intocloudflare:masterfrom
jacobbednarz merged 2 commits intocloudflare:masterfrom
Conversation
jacobbednarz
reviewed
Nov 2, 2021
Contributor
jacobbednarz
left a comment
jacobbednarz
left a comment
There was a problem hiding this comment.
couple of inline comments but looks great. would you mind also adding a test for this new endpoint please?
priyakvs
force-pushed
the
master
branch
3 times, most recently
from
273a5ba to
618f711
Compare
jacobbednarz
reviewed
Nov 3, 2021
Contributor
|
thank you @priyakvs, this is awesome 🍭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding cloudflare-go integration for alert history API to notifications.go