Skip to content

add waiting room custom page preview#816

Merged
jacobbednarz merged 2 commits intocloudflare:masterfrom
broswen:add-waiting-room-page-preview
Feb 27, 2022
Merged

add waiting room custom page preview#816
jacobbednarz merged 2 commits intocloudflare:masterfrom
broswen:add-waiting-room-page-preview

Conversation

@broswen
Copy link
Copy Markdown

@broswen broswen commented Feb 24, 2022

Description

Adds a method to upload a custom waiting room page preview.
https://api.cloudflare.com/#waiting-room-create-a-custom-waiting-room-page-preview

Has your change been tested?

Yes, a test has been added to waiting_room_test.go.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Comment thread waiting_room.go Outdated
@jacobbednarz jacobbednarz merged commit c09458f into cloudflare:master Feb 27, 2022
@jacobbednarz
Copy link
Copy Markdown
Contributor

that is great, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants