Added changeDevelopmentMode & getAnalyticsDashboard to Zones

[TylerVigario]

No description provided.

[thellimist]

Could you run linter? (Fixing CI)

Thanks

[IcyApril]

+1 @thellimist

@MeekLogic - Thanks for contributing. Could you also make sure you add an associated test for this method in tests/Endpoints/ZonesTest.php ?

Thanks!

[TylerVigario]

Just seen this, will add the appropriate test shortly.

EDIT: Might be stupid but I think I made a proper test but I don't really know how to test.

[IcyApril]

OK, thanks @MeekLogic. All that's left is to fix the build - could you please run make fix and then commit the changes?

Alternatively if you cd into the project directory, you can probably get away with just running something like:

php ./vendor/bin/php-cs-fixer fix --config=.php_cs

[TylerVigario]

@IcyApril Thank you very much for pointing me in the right direction.

Threw the PHP CS Fixer PHAR in the directory and ran the command and it worked like magic!

Side note: What environment (OS) are you using? Or is this like some Docker thing lol. I need to get with this CI/CD stuff.

[thellimist]

We're using Travis CI. https://github.com/cloudflare/cloudflare-php/blob/master/.travis.yml
For style control we're using phpcs-fixer and phpmd.
And a Makefile https://github.com/cloudflare/cloudflare-php/blob/master/Makefile

Hope this answers your question.

Thanks

[TylerVigario]

Thanks @thellimist but I could have gathered that information. What I could not ascertain is what is required of someone to issue those commands within their local environment.

[IcyApril]

string $since = "-10080", string $until = "0"

Should these be integers or strings?

[IcyApril]

@MeekLogic Try switching to assertObjectHasAttribute as is the case in testListZones:

        $this->assertObjectHasAttribute('result', $result);
        $this->assertObjectHasAttribute('result_info', $result);
        $this->assertEquals("023e105f4ecef8ad9ca31a8372d0c353", $result->result[0]->id);
        $this->assertEquals(1, $result->result_info->page);

[TylerVigario]

@IcyApril I believe strings, in the curl example he sends timestamp values

This value can be a negative integer representing the number of minutes in the past relative to time the request is made, or can be an absolute timestamp that conforms to RFC 3339.

https://api.cloudflare.com/#zone-analytics-dashboard

[IcyApril]

Yeah, that should be fine. We should just make sure the tests are appropriate.

[TylerVigario]

Installing PHPMD within VSCode to fix those pesky errors.

Edit: It doesn't like the boolean parameters for some reason

The method changeDevelopmentMode has a boolean flag argument $enable, which is a certain sign of a Single Responsibility Principle violation.