Fixes for systemd seqpacket sockets#16
Merged
molguin92 merged 3 commits intocloudflare:mainfrom Apr 14, 2026
Merged
Conversation
Contributor
|
nit: on mac OS at least, |
143a53a to
3d215af
Compare
Contributor
Author
|
fixed imports to use the correct feature flag |
molguin92
reviewed
Apr 10, 2026
Contributor
molguin92
left a comment
There was a problem hiding this comment.
nit: please run cargo sort to make sure Cargo.toml is properly formatted (unrelated to these changes but would be nice 🙏🏽 ).
Left some other comments here and there too, but lgtm otherwise.
3d215af to
d831b0d
Compare
Contributor
|
all good, 🚢 it |
molguin92
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #13
This corrects a couple issues from my previous PR:
UnixSeqpacketListenerStreamfor users ofsystemd_listen_unix_seqpacketaccept4's manpage :s We do need to explicitly setO_NONBLOCKbefore accepting connections. I usedfcntlsince tokio-seqpacket does not give us aset_nonblockingmethod.