Skip to content

Fixes for systemd seqpacket sockets#16

Merged
molguin92 merged 3 commits intocloudflare:mainfrom
wes-fournier:wfournier/export-seqpacket-stream
Apr 14, 2026
Merged

Fixes for systemd seqpacket sockets#16
molguin92 merged 3 commits intocloudflare:mainfrom
wes-fournier:wfournier/export-seqpacket-stream

Conversation

@wes-fournier
Copy link
Copy Markdown
Contributor

Addresses #13

This corrects a couple issues from my previous PR:

  • Reexport UnixSeqpacketListenerStream for users of systemd_listen_unix_seqpacket
  • I misread accept4's manpage :s We do need to explicitly set O_NONBLOCK before accepting connections. I used fcntl since tokio-seqpacket does not give us a set_nonblocking method.

@molguin92 molguin92 self-requested a review April 10, 2026 16:07
@molguin92 molguin92 self-assigned this Apr 10, 2026
@molguin92
Copy link
Copy Markdown
Contributor

nit: on mac OS at least, cargo clippy throws "unused import" warnings

Checking ecdysis v1.1.0 (/Users/molguin/workspace/ecdysis)
warning: unused imports: `FromRawFd` and `RawFd`
 --> src/listener.rs:5:14
  |
5 |         fd::{FromRawFd, RawFd},
  |              ^^^^^^^^^  ^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

warning: `ecdysis` (lib) generated 1 warning (run `cargo clippy --fix --lib -p ecdysis` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.78s

@wes-fournier wes-fournier force-pushed the wfournier/export-seqpacket-stream branch from 143a53a to 3d215af Compare April 10, 2026 16:52
@wes-fournier
Copy link
Copy Markdown
Contributor Author

fixed imports to use the correct feature flag

Copy link
Copy Markdown
Contributor

@molguin92 molguin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please run cargo sort to make sure Cargo.toml is properly formatted (unrelated to these changes but would be nice 🙏🏽 ).

Left some other comments here and there too, but lgtm otherwise.

Comment thread src/seqpacket.rs Outdated
Comment thread src/seqpacket.rs Outdated
@wes-fournier wes-fournier force-pushed the wfournier/export-seqpacket-stream branch from 3d215af to d831b0d Compare April 10, 2026 18:26
@molguin92
Copy link
Copy Markdown
Contributor

all good, 🚢 it

@molguin92 molguin92 merged commit 74617ea into cloudflare:main Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants