ci(semgrep): pin token to contents: read#205
Merged
Merged
Conversation
The semgrep scheduled scan only checks out the repo and runs `semgrep ci` against Cloudflare's internal Semgrep endpoint. The GitHub token doesn't need any write scopes. The sibling `ci.yml` already declares a top-level permissions block, this matches that style. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
b749353 to
54dddd2
Compare
Contributor
Author
|
Hi @TheJokr, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
TheJokr
approved these changes
May 18, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENto read-only forsemgrep.yml. The scheduled Semgrep scan only checks out the repo and posts findings to Cloudflare's internal Semgrep instance viaSEMGREP_APP_TOKEN, so the GitHub token only needs read access to the checkout.Brings the workflow in line with the existing
permissions: contents: readblock inci.yml. YAML validated withyaml.safe_load.