Skip to content

fix(docs): add missing success variant to Badge page#239

Merged
mattrothenberg merged 1 commit intocloudflare:mainfrom
pedromenezes1:fix/badge-demo-missing-success-variant
Mar 17, 2026
Merged

fix(docs): add missing success variant to Badge page#239
mattrothenberg merged 1 commit intocloudflare:mainfrom
pedromenezes1:fix/badge-demo-missing-success-variant

Conversation

@pedromenezes1
Copy link
Copy Markdown
Collaborator

@pedromenezes1 pedromenezes1 commented Mar 17, 2026

The Badge docs page was missing the success variant in two places, despite it being implemented in the component and already present in the demo file (BadgeDemo.tsx).

Changes

  • Added <Badge variant="success">Success</Badge> to the top demo code snippet
  • Added the Success variant example in the Variants section (between Destructive and Outline)
  • Added BadgeSuccessDemo import
Before After
Screenshot 2026-03-17 at 13 54 33 Screenshot 2026-03-17 at 13 53 55
Screenshot 2026-03-17 at 13 54 40 Screenshot 2026-03-17 at 13 54 09

The Badge page demo and Variants section were missing the success
variant, despite it being implemented in the component and demo file.
@pedromenezes1 pedromenezes1 force-pushed the fix/badge-demo-missing-success-variant branch from c17d8c0 to edcbde3 Compare March 17, 2026 13:57
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Mar 17, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@239

commit: edcbde3

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: edcbde3

@mattrothenberg mattrothenberg merged commit 8d14b75 into cloudflare:main Mar 17, 2026
8 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report

5 screenshot(s) with visual changes:

Button / Variants

20,282 px (1.47%) changed

Before After Diff
Before After Diff

Button / Loading State

8 px (0%) changed

Before After Diff
Before After Diff

Dialog / Basic Dialog

128,213 px (2.45%) changed

Before After Diff
Before After Diff

Select / Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
21 screenshot(s) unchanged
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Dialog / Alert Dialog (role="alertdialog")
  • Dialog / Confirmation Dialog (with disablePointerDismissal)
  • Dialog / With Actions
  • Dialog / With Select
  • Dialog / With Combobox
  • Dialog / With Dropdown
  • Dialog (Open)
  • Select / Basic Usage
  • Select / Without Visible Label
  • Select / With Description and Error
  • Select / Placeholder
  • Select / Label with Tooltip
  • Select / Custom Rendering
  • Select / Multiple Item
  • Select / More Example
  • Select / Select
  • Select / Select.Option

Generated by Kumo Visual Regression

@pedromenezes1 pedromenezes1 deleted the fix/badge-demo-missing-success-variant branch March 17, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants