Skip to content

Fix Radio Card docs order and headings#267

Merged
mattrothenberg merged 2 commits intocloudflare:mainfrom
pedromenezes1:fix/radio-card-docs-order
Mar 19, 2026
Merged

Fix Radio Card docs order and headings#267
mattrothenberg merged 2 commits intocloudflare:mainfrom
pedromenezes1:fix/radio-card-docs-order

Conversation

@pedromenezes1
Copy link
Copy Markdown
Collaborator

Fix the Radio Card documentation to match the original PR #230:

  • Rename 'Card Appearance' to 'Radio Card'
  • Rename 'Card Appearance (Horizontal)' to 'Radio Card (Horizontal)'
  • Reorder examples so Control Position comes before Radio Card sections
  • Update description text to match original PR [kumo] feat: add radio card appearance #230

- Rename 'Card Appearance' to 'Radio Card' to match original PR cloudflare#230
- Reorder examples: Control Position now before Radio Card sections
- Update description text for Radio Card sections
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 19, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@267

commit: 00ee700

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

Docs Preview

View docs preview

Commit: 00ee700

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

Visual Regression Report

14 screenshot(s) with visual changes:

Button / Variants

6 px (0%) changed

Before After Diff
Before After Diff

Button / Sizes

10 px (0%) changed

Before After Diff
Before After Diff

Button / With Icon

41,163 px (1.41%) changed

Before After Diff
Before After Diff

Button / Icon Only

3 px (0%) changed

Before After Diff
Before After Diff

Button / Loading State

6 px (0%) changed

Before After Diff
Before After Diff

Button / Disabled State

4 px (0%) changed

Before After Diff
Before After Diff

Dialog / Basic Dialog

133,224 px (2.41%) changed

Before After Diff
Before After Diff

Dialog / Confirmation Dialog (with disablePointerDismissal)

20,830 px (0.38%) changed

Before After Diff
Before After Diff

Dialog / With Actions

134,168 px (2.42%) changed

Before After Diff
Before After Diff

Dialog / With Select

96,053 px (1.73%) changed

Before After Diff
Before After Diff

Select / Basic Usage

13,639 px (2.32%) changed

Before After Diff
Before After Diff

Select / Label with Tooltip

13,623 px (1.94%) changed

Before After Diff
Before After Diff

Select / Loading

13,845 px (1.95%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
12 screenshot(s) unchanged
  • Dialog / Alert Dialog (role=“alertdialog”)
  • Dialog / With Combobox
  • Dialog / With Dropdown
  • Dialog (Open)
  • Select / Without Visible Label
  • Select / With Description and Error
  • Select / Placeholder
  • Select / Custom Rendering
  • Select / Multiple Item
  • Select / More Example
  • Select / Select
  • Select / Select.Option

Generated by Kumo Visual Regression

Change Radio export from plain object literal to Object.assign(RadioGroup, {...})
to match the convention used by all other compound components. This allows the
registry codegen to detect Radio.Group and Radio.Item as sub-components,
fixing the broken PropsTable in the docs.
@mattrothenberg mattrothenberg merged commit 9fbf3a8 into cloudflare:main Mar 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants