Skip to content

fix(select): use ring-kumo-hairline token missed in PR #355#379

Merged
mattrothenberg merged 2 commits intomainfrom
rothenberg/fix-select-lint
Apr 8, 2026
Merged

fix(select): use ring-kumo-hairline token missed in PR #355#379
mattrothenberg merged 2 commits intomainfrom
rothenberg/fix-select-lint

Conversation

@mattrothenberg
Copy link
Copy Markdown
Collaborator

Summary

PR #355 updated ring-kumo-ring to ring-kumo-hairline in two places in select.tsx but missed the third occurrence at line 397 (the Select.Popup className). This causes lint to fail on main.

Checklist

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 8, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@379

commit: a0919d7

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Docs Preview

View docs preview

Commit: 83afa49

@mattrothenberg
Copy link
Copy Markdown
Collaborator Author

/bonk wdyt about this

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Visual Regression Report

12 screenshot(s) with visual changes:

Select / Select Without Label

103 px (0.1%) changed

Before After Diff
Before After Diff

Select / Select With Field

796 px (0.68%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

690 px (0.68%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

591 px (0.58%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

412 px (0.41%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Disabled Options

932 px (0.92%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

224 px (0.22%) changed

Before After Diff
Before After Diff

Select / Select Grouped

406 px (0.4%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

729 px (0.72%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,728 px (1.46%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
3 screenshot(s) unchanged
  • Select / Select Basic
  • Select / Select Multiple
  • Select / Select Complex

Generated by Kumo Visual Regression

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This correctly updates the remaining 'ring-kumo-ring' token to 'ring-kumo-hairline' in the Select popup, matching the changes made in PR #355. The fix follows the project's semantic token conventions and resolves the lint failure on main.

@mattrothenberg mattrothenberg merged commit e8bcf6f into main Apr 8, 2026
17 checks passed
@mattrothenberg mattrothenberg deleted the rothenberg/fix-select-lint branch April 8, 2026 17:51
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 8, 2026

Approved PR #379

Summary of changes:

  • Fixed the Select popup component at line 397 to use ring-kumo-hairline instead of ring-kumo-ring
  • Added a proper changeset documenting the patch fix
  • This aligns with PR feat(tokens): updated color docs and ring #355's changes and follows the project's semantic token conventions
  • Resolves the lint failure on main branch

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants