fix(select): use ring-kumo-hairline token missed in PR #355#379
Merged
mattrothenberg merged 2 commits intomainfrom Apr 8, 2026
Merged
fix(select): use ring-kumo-hairline token missed in PR #355#379mattrothenberg merged 2 commits intomainfrom
mattrothenberg merged 2 commits intomainfrom
Conversation
geoquant
approved these changes
Apr 8, 2026
commit: |
Contributor
Docs PreviewCommit: |
Collaborator
Author
|
/bonk wdyt about this |
Contributor
Contributor
There was a problem hiding this comment.
LGTM. This correctly updates the remaining 'ring-kumo-ring' token to 'ring-kumo-hairline' in the Select popup, matching the changes made in PR #355. The fix follows the project's semantic token conventions and resolves the lint failure on main.
Contributor
|
✅ Approved PR #379 Summary of changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




































Summary
PR #355 updated
ring-kumo-ringtoring-kumo-hairlinein two places in select.tsx but missed the third occurrence at line 397 (the Select.Popup className). This causes lint to fail on main.Checklist
bonk has reviewed the change
Additional testing not necessary because: This is a one-line token rename to match what PR feat(tokens): updated color docs and ring #355 already did for the other two occurrences. Lint now passes.