fix(buttons): white border around secondary buttons in pagination

[najlaskr]

This fixes unwanted white borders around the next and previous buttons in Pagination with the new InputGroup replacement in stratus by removing not-disabled:hover:border-secondary!

Before

After

---

• Reviews
  • bonk has reviewed the change
  • automated review not possible because: no access to bonk
• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows: pnpm lint, pnpm typecheck and visual QA
  • Additional testing not necessary because:

[mattrothenberg]

/bonk

[ask-bonk]

PR Summary: Fix White Border Around Secondary Buttons in Pagination

Overview

This PR fixes unwanted white borders appearing around next/previous buttons in the Pagination component when used with the new InputGroup replacement in stratus.

Changes

1. packages/kumo/src/components/button/button.tsx

• Removes not-disabled:hover:border-secondary! from the secondary button variant class string
• Removes not-disabled:hover:border-secondary! from the secondary-destructive button variant class string

2. .changeset/button-secondary-hover-border-cleanup.md

• Adds a patch changeset for @cloudflare/kumo

Analysis

The border-secondary utility class doesn't appear to be defined in the project's Tailwind configuration, which was causing it to render as a default/white border on hover. Since the secondary buttons already have ring and ring-kumo-hairline for their border appearance, the removed class was redundant and causing visual issues.

Review Status

• ✅ Clean, minimal fix targeting the root cause
• ✅ Proper changeset included
• ✅ Before/after screenshots provided
• ✅ Manual testing completed (lint, typecheck, visual QA)
• ⚠️ Note: The PR description mentions the InputGroup replacement in "stratus" — this appears to be an internal Cloudflare project context not present in this repo. The fix is correct regardless of the consuming application.

github run

[pkg-pr-new]

npm i https://pkg.pr.new/@cloudflare/kumo@457

commit: 6bdbab1

[github-actions]

Docs Preview

View docs preview

Commit: 6bdbab1

[github-actions]

Visual Regression Report — 4 changed, 10 unchanged

4 screenshot(s) with visual changes:

Button / Variant: Destructive

585 px (0.58%) changed

Before	After	Diff

Button / Sizes

702 px (0.69%) changed

Before	After	Diff

Button / Loading State

3 px (0%) changed

Before	After	Diff

Button / Disabled State

117 px (0.12%) changed

Before	After	Diff

10 screenshot(s) unchanged

• Button / Basic
• Button / Variant: Primary
• Button / Variant: Secondary
• Button / Variant: Ghost
• Button / Variant: Outline
• Button / Variant: Secondary Destructive
• Button / With Icon
• Button / Icon Only
• Button / Title
• Button / Link as Button

---

Generated by Kumo Visual Regression