Skip to content

fix(radio): add shrink-0 to prevent oval distortion with long labels#509

Merged
mattrothenberg merged 1 commit into
mainfrom
fix/radio-shrink-distortion
May 12, 2026
Merged

fix(radio): add shrink-0 to prevent oval distortion with long labels#509
mattrothenberg merged 1 commit into
mainfrom
fix/radio-shrink-distortion

Conversation

@mattrothenberg
Copy link
Copy Markdown
Collaborator

Summary

  • Adds missing shrink-0 to the default appearance radio indicator, preventing the radio button from being squished into an oval when paired with long labels

  • The card appearance already had shrink-0; this brings the default path in line

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: trivial one-class CSS fix

  • Tests

  • Additional testing not necessary because: single Tailwind utility addition with no behavioral change

@mattrothenberg
Copy link
Copy Markdown
Collaborator Author

/bonk approve please

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Simple, focused fix that brings the default radio appearance in line with the card appearance. The shrink-0 prevents the radio button from being squished into an oval when paired with long labels—classic flexbox gotcha. Changeset is present and correctly scoped.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 12, 2026

Approved PR #509

The fix adds shrink-0 to prevent radio button distortion with long labels—aligning the default appearance with the existing card appearance behavior. Clean, minimal, and well-documented with a changeset.

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@509

commit: 8c43aca

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: bc43577

@mattrothenberg mattrothenberg merged commit 862389a into main May 12, 2026
16 checks passed
@mattrothenberg mattrothenberg deleted the fix/radio-shrink-distortion branch May 12, 2026 21:06
@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report — 11 changed, 2 unchanged

11 screenshot(s) with visual changes:

Radio / Radio Basic

1,282 px (0.94%) changed

Before After Diff
Before After Diff

Radio / Radio Horizontal

937 px (0.92%) changed

Before After Diff
Before After Diff

Radio / Radio Description

2,534 px (1.54%) changed

Before After Diff
Before After Diff

Radio / Radio Card

5,299 px (1.67%) changed

Before After Diff
Before After Diff

Radio / Radio Card Control Start

4,105 px (2.16%) changed

Before After Diff
Before After Diff

Radio / Radio Rich Label

1,188 px (0.62%) changed

Before After Diff
Before After Diff

Radio / Radio Card Horizontal

4,610 px (2.14%) changed

Before After Diff
Before After Diff

Radio / Radio Error

4,811 px (2.22%) changed

Before After Diff
Before After Diff

Radio / Radio Disabled

1,073 px (0.38%) changed

Before After Diff
Before After Diff

Radio / Radio Legend Sr Only

632 px (0.62%) changed

Before After Diff
Before After Diff

Radio / Radio Legend Custom

287 px (0.23%) changed

Before After Diff
Before After Diff
2 screenshot(s) unchanged
  • Radio / Radio Default
  • Radio / Radio Control Position

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant