Skip to content

feat(input): add password manager ignore prop#511

Merged
mattrothenberg merged 3 commits into
cloudflare:mainfrom
awhobbs87:ahobbs/input-password-manager-ignore
May 14, 2026
Merged

feat(input): add password manager ignore prop#511
mattrothenberg merged 3 commits into
cloudflare:mainfrom
awhobbs87:ahobbs/input-password-manager-ignore

Conversation

@awhobbs87
Copy link
Copy Markdown
Contributor

Summary

  • Add an opt-in passwordManagerIgnore prop to Input for non-credential fields that password managers misclassify.
  • Apply common password manager suppression hints, including Keeper's documented keeper-ignore class.
  • Document the prop and cover the emitted hints in the Input tests.

Testing

  • pnpm --filter @cloudflare/kumo exec vitest run --project=unit src/components/input/input.test.tsx
  • pnpm exec prettier --check packages/kumo/src/components/input/input.tsx packages/kumo/src/components/input/input.test.tsx packages/kumo-docs-astro/src/pages/components/input.mdx .changeset/input-password-manager-ignore.md

Local Check Notes

  • pnpm typecheck is currently blocked in this checkout by Node 22.22.1 vs required 24.12.0, missing screenshot-worker dependencies, and missing generated registry/schema state.

  • pnpm --filter @cloudflare/kumo typecheck and pnpm --filter @cloudflare/kumo lint are also blocked by missing generated packages/kumo/ai/component-registry.json and dependency mismatches in the local checkout.

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: this PR was opened by an agent before Bonk review

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows:

  • Additional testing not necessary because:

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@511

commit: 3ba6c02

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Docs Preview

View docs preview

Commit: 3ba6c02

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Visual Regression Report — 8 changed, 30 unchanged

8 screenshot(s) with visual changes:

Button / Sizes

477 px (0.47%) changed

Before After Diff
Before After Diff

Button / Loading State

8 px (0.01%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

170 px (0.09%) changed

Before After Diff
Before After Diff

Select / Select With Field

635 px (0.54%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

294 px (0.29%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select (Open)

814 px (0%) changed

Before After Diff
Before After Diff
30 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Dialog / Dialog With Actions
  • Dialog / Dialog Basic
  • Dialog / Dialog Alert
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Select
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select Without Label
  • Select / Select Placeholder
  • Select / Select Custom Rendering
  • Select / Select Multiple
  • Select / Select Complex
  • Select / Select Disabled Options
  • Select / Select Disabled Items
  • Select / Select Grouped
  • Select / Select Grouped With Disabled
  • Select / Select Long List

Generated by Kumo Visual Regression

Comment thread packages/kumo/src/components/input/input.tsx Outdated
ahobbs-cf and others added 3 commits May 14, 2026 09:58
Keeper's docs only document the keeper-ignore CSS class for
suppressing overlays. data-keeper-lock is not in their docs.
@mattrothenberg mattrothenberg force-pushed the ahobbs/input-password-manager-ignore branch from 86619f4 to 3ba6c02 Compare May 14, 2026 14:02
@mattrothenberg mattrothenberg merged commit 228a9c4 into cloudflare:main May 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants