Skip to content

Expose optionUpdateBehavior prop on TimeseriesChart#512

Merged
mattrothenberg merged 2 commits into
cloudflare:mainfrom
invisal:expose-optionUpdateBehavior-timeserieschart
May 14, 2026
Merged

Expose optionUpdateBehavior prop on TimeseriesChart#512
mattrothenberg merged 2 commits into
cloudflare:mainfrom
invisal:expose-optionUpdateBehavior-timeserieschart

Conversation

@invisal
Copy link
Copy Markdown
Contributor

@invisal invisal commented May 14, 2026

This PR exposes the optionUpdateBehavior prop on TimeseriesChart, allowing consumers to control how ECharts applies option updates (e.g., notMerge, lazyUpdate, replaceMerge). The prop was already available on the low-level Chart component; this change simply passes it through from the higher-level TimeseriesChart.

  • Reviews
  • bonk has reviewed the change
  • automated review not possible because: trivial prop pass-through
  • Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because: trivial prop pass-through from Chart component

@mattrothenberg
Copy link
Copy Markdown
Collaborator

/bonk

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@512

commit: 7060479

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 14, 2026

PR Summary: Expose optionUpdateBehavior prop on TimeseriesChart

What changed:

  • Added the optionUpdateBehavior prop to TimeseriesChartProps interface, allowing consumers to control how ECharts applies option updates (e.g., notMerge, lazyUpdate, replaceMerge)
  • The prop is destructured and passed through to the underlying Chart component

Files changed:

  1. .changeset/expose-optionUpdateBehavior-timeserieschart.md (new) - Patch changeset documenting the addition
  2. packages/kumo/src/components/chart/TimeseriesChart.tsx - Added prop to interface and passed it to the Chart component

Key code changes:

// Added to TimeseriesChartProps (lines 91-94)
optionUpdateBehavior?: SetOptionOpts;

// Destructured (line 146)
optionUpdateBehavior,

// Passed to Chart component (line 401)
optionUpdateBehavior={optionUpdateBehavior}

Review assessment:

  • ✅ Simple, non-breaking change (prop pass-through)
  • ✅ Properly typed using existing SetOptionOpts type from ECharts
  • ✅ Changeset included for patch release
  • ✅ PR description checklist completed appropriately

This is a straightforward enhancement that exposes existing functionality from the low-level Chart component to the higher-level TimeseriesChart wrapper.

github run

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 7060479

@mattrothenberg mattrothenberg merged commit 974277f into cloudflare:main May 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants