fix(input): render error and description without requiring label#513
Merged
Conversation
Input and InputArea silently dropped error and description props when no label was provided, because the Field wrapper was only rendered in the label branch. Now the Field wrapper renders whenever label, error, or description is present. Extracts normalizeFieldError helper to deduplicate the string-to-object error conversion used across multiple components.
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Collaborator
Author
|
/bonk review and approve |
Contributor
|
✅ Review submitted and approved for PR #513. The fix correctly addresses the bug where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







































Summary
InputandInputAreasilently droppederroranddescriptionprops when nolabelwas provided, because the<Field>wrapper was only rendered in theif (label)branchif (label || error || description)so the Field wrapper renders whenever there's content to displaynormalizeFieldError()helper to deduplicate thestring | objecterror normalization repeated 7x across componentsReported by Ana Foppa -- passing
erroras a prop to Input without a label showed the red ring but no error message text.