Skip to content

fix(sidebar): Last minute tweaks and nits#545

Merged
mattrothenberg merged 7 commits into
cloudflare:sidebar-modernizationfrom
hkfoster:sidebar-modernization
May 28, 2026
Merged

fix(sidebar): Last minute tweaks and nits#545
mattrothenberg merged 7 commits into
cloudflare:sidebar-modernizationfrom
hkfoster:sidebar-modernization

Conversation

@hkfoster
Copy link
Copy Markdown

Summary

Fixes several visual and interaction issues in the collapsed sidebar:

  • Tooltip stability: Always wrap MenuButton in Tooltip when tooltip prop is provided, keeping DOM structure stable across expand/collapse to preserve CSS transitions. Pass content={null} when tooltip should be suppressed (expanded state or peekable enabled).
  • Peekable tooltip suppression: Added peekable to sidebar context so MenuButton can disable tooltips when peeking is enabled (tooltips are redundant when hovering reveals the full sidebar).
  • Explicit transition properties: Replaced transition-all with transition-[color,background-color,box-shadow,outline] on MenuButton per Web Interface Guidelines.
  • Smooth ring transition: Changed ring-0 to ring-transparent on search button demo so the ring animates out instead of snapping.
  • Overflow-based text clipping: Removed hidden classes from text spans in demos, relying on overflow-hidden + min-w-0 for smooth width-driven clipping during collapse.
  • Caret icon transition: Wrapped CaretUpDownIcon in a span with transition-[width] for smooth hide/show in AccountSwitcher.
  • Sliding views fix: Removed invisible from inactive SlidingView panels — it was hiding the outgoing view instantly mid-slide. Parent overflow-hidden clips off-screen views; aria-hidden + inert handle accessibility.
  • Resize handle styling: Updated to after:w-0.5 with bg-kumo-hairline tokens.
  • Stale comment cleanup: Removed outdated comment about avoiding transitions.

  • Reviews
  • bonk has reviewed the change
  • automated review not possible because: visual polish fixes requiring manual verification
  • Tests
  • Tests included/updated
  • Additional testing not necessary because: changes are CSS/styling only with no behavioral changes; existing tests pass (2 pre-existing inert failures unrelated)

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@545

commit: 86b7cb8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Docs Preview

View docs preview

Commit: 86b7cb8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Visual Regression Report — 19 changed, 18 unchanged

19 screenshot(s) with visual changes:

Button / Variant: Ghost

175 px (0.17%) changed

Before After Diff
Before After Diff

Button / Icon Only

76 px (0.07%) changed

Before After Diff
Before After Diff

Button / Loading State

199 px (0.2%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

200 px (0.2%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,427 px (1.41%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

130 px (0.13%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

130 px (0.13%) changed

Before After Diff
Before After Diff

Dialog (Open)

189,387 px (0.94%) changed

Before After Diff
Before After Diff

Select / Select Basic

300 px (0.3%) changed

Before After Diff
Before After Diff

Select / Select Sizes

947 px (0.51%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

413 px (0.41%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,093 px (1.04%) changed

Before After Diff
Before After Diff

Select / Select Multiple

556 px (0.55%) changed

Before After Diff
Before After Diff

Select / Select Complex

720 px (0.61%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

231 px (0.23%) changed

Before After Diff
Before After Diff

Select / Select Grouped

346 px (0.34%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

450 px (0.44%) changed

Before After Diff
Before After Diff

Select (Open)

818,991 px (3.24%) changed

Before After Diff
Before After Diff
18 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Dialog / Dialog Basic
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Combobox
  • Select / Select Without Label
  • Select / Select With Tooltip
  • Select / Select Disabled Options
  • Select / Select Long List

Generated by Kumo Visual Regression

@hkfoster hkfoster force-pushed the sidebar-modernization branch from a8749e7 to 848e3aa Compare May 28, 2026 00:08
Comment thread packages/kumo/.oxlintrc.json Outdated
@mattrothenberg
Copy link
Copy Markdown
Collaborator

/bonk please review

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 28, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 28, 2026

@mattrothenberg Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@mattrothenberg mattrothenberg merged commit a4f977f into cloudflare:sidebar-modernization May 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants