fix(sidebar): Last minute tweaks and nits#545
Merged
mattrothenberg merged 7 commits intoMay 28, 2026
Merged
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
a8749e7 to
848e3aa
Compare
Brayden
reviewed
May 28, 2026
Collaborator
|
/bonk please review |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@mattrothenberg Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
a4f977f
into
cloudflare:sidebar-modernization
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






















































Summary
Fixes several visual and interaction issues in the collapsed sidebar:
MenuButtonin Tooltip whentooltipprop is provided, keeping DOM structure stable across expand/collapse to preserve CSS transitions. Passcontent={null}when tooltip should be suppressed (expanded state or peekable enabled).peekableto sidebar context soMenuButtoncan disable tooltips when peeking is enabled (tooltips are redundant when hovering reveals the full sidebar).transition-allwithtransition-[color,background-color,box-shadow,outline]onMenuButtonper Web Interface Guidelines.ring-0toring-transparenton search button demo so the ring animates out instead of snapping.hiddenclasses from text spans in demos, relying onoverflow-hidden+min-w-0for smooth width-driven clipping during collapse.CaretUpDownIconin a span withtransition-[width]for smooth hide/show in AccountSwitcher.invisiblefrom inactiveSlidingViewpanels — it was hiding the outgoing view instantly mid-slide. Parentoverflow-hiddenclips off-screen views;aria-hidden+inerthandle accessibility.after:w-0.5withbg-kumo-hairlinetokens.