Skip to content

fix: use explicit context providers #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrothenberg merged 1 commit into from
May 29, 2026
+9 −4
Merged

fix: use explicit context providers #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-react-18-context-providers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/kumo": patch
---

Fix Combobox and Autocomplete rendering in React 18 by using the explicit context provider API.
4 changes: 2 additions & 2 deletions packages/kumo/src/components/autocomplete/autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ function Root<ItemValue>({
items?: readonly ItemValue[];
};
const control = (
<AutocompleteContext value={{ hasError: Boolean(error) }}>
<AutocompleteContext.Provider value={{ hasError: Boolean(error) }}>
<AutocompleteBase.Root {...rootProps}>{children}</AutocompleteBase.Root>
</AutocompleteContext>
</AutocompleteContext.Provider>
);

if (label) {
Expand Down
4 changes: 2 additions & 2 deletions packages/kumo/src/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ function Root<Value, Multiple extends boolean | undefined = false>({
size?: KumoComboboxSize;
}) {
const comboboxControl = (
<ComboboxContext value={{ size, hasError: Boolean(error) }}>
<ComboboxContext.Provider value={{ size, hasError: Boolean(error) }}>
<ComboboxBase.Root {...props}>{children}</ComboboxBase.Root>
</ComboboxContext>
</ComboboxContext.Provider>
);

// Render with Field wrapper if label, description, or error are provided
Expand Down
Loading