Reject all browser-recognized comment-closing sequences in Comment::set_text.#322
Merged
Conversation
orium
force-pushed
the
fix-text-comment-breakout
branch
from
cc613c7 to
c6b1c73
Compare
scotchmist
approved these changes
May 26, 2026
orium
force-pushed
the
fix-text-comment-breakout
branch
from
c6b1c73 to
b7b9bf4
Compare
fisherdarling
approved these changes
May 29, 2026
…et_text. Previously `Comment::set_text` only rejected the canonical `-->` terminator, but a WHATWG-conformant browser also closes a comment on three more byte sequences: 1. `--!>` anywhere in the body (comment-end-bang state). 2. A leading `>` (abrupt-closing-of-empty-comment from comment-start). 3. A leading `->` (abrupt-closing-of-empty-comment from comment-start-dash).
orium
force-pushed
the
fix-text-comment-breakout
branch
from
b7b9bf4 to
ffcca31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
Comment::set_textonly rejected the canonical-->terminator, but a WHATWG-conformant browser also closes a comment on three more byte sequences:--!>anywhere in the body (comment-end-bang state).>(abrupt-closing-of-empty-comment from comment-start).->(abrupt-closing-of-empty-comment from comment-start-dash).