Fix initialization race conditions and improve error resilience. #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `getServerByName` now propagates errors from the internal `set-name` request instead of silently swallowing them. - `onStart` failures no longer permanently brick the Durable Object. Errors are caught inside `blockConcurrencyWhile` (preserving the input gate) and the status is reset, allowing subsequent requests to retry initialization. - `fetch()` now retries initialization when a previous `onStart` attempt failed, instead of skipping it because the name was already set. - Errors in `fetch()` (including `onStart` failures and malformed props) are now caught and returned as proper 500 responses instead of crashing as unhandled exceptions. - WebSocket handlers (`webSocketMessage`, `webSocketClose`, `webSocketError`) are now wrapped in try/catch so that transient `onStart` failures don't kill the connection — the next message will retry.
🦋 Changeset detectedLatest commit: 8fe851c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getServerByNamenow propagates errors from the internalset-namerequest instead of silently swallowing them.onStartfailures no longer permanently brick the Durable Object. Errors are caught insideblockConcurrencyWhile(preserving the input gate) and the status is reset, allowing subsequent requests to retry initialization.fetch()now retries initialization when a previousonStartattempt failed, instead of skipping it because the name was already set.fetch()(includingonStartfailures and malformed props) are now caught and returned as proper 500 responses instead of crashing as unhandled exceptions.webSocketMessage,webSocketClose,webSocketError) are now wrapped in try/catch so that transientonStartfailures don't kill the connection — the next message will retry.