Expose lobby.className and deprecate party #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Lobby type and pass a lobby object to onBeforeConnect/onBeforeRequest that includes className (the Durable Object env binding/class name) and name, while marking lobby.party (kebab-case namespace) as deprecated. Implement bindingNameCache to map kebab-case namespaces to original env binding names, update server map initialization to populate both caches, and add a deprecation warning when lobby.party is accessed. Update tests and test worker to use lobby.className and add a test that verifies the className is returned. Also add a changeset declaring the behavioral change and upcoming major-version change to lobby.party.
🦋 Changeset detectedLatest commit: 9c74fd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Upgrade partyserver from ^0.1.4 to ^0.1.5 in multiple package.json files (hono-party, partysub, partysync, partywhen, y-partyserver) and update package-lock.json. Applies to both devDependencies and regular dependencies where applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #279
Add a Lobby type and pass a lobby object to onBeforeConnect/onBeforeRequest that includes className (the Durable Object env binding/class name) and name, while marking lobby.party (kebab-case namespace) as deprecated. Implement bindingNameCache to map kebab-case namespaces to original env binding names, update server map initialization to populate both caches, and add a deprecation warning when lobby.party is accessed. Update tests and test worker to use lobby.className and add a test that verifies the className is returned. Also add a changeset declaring the behavioral change and upcoming major-version change to lobby.party.