Update quickstart to support Opt::parse_args#433
Closed
gth828r wants to merge 1 commit into
Closed
Conversation
The current quickstart document suggests to use pingora v0.1, but it also suggests using the Opt::parse_args interface, which was introduced in release v0.3.0. Update the quickstart document to suggest using v0.3 when setting up the cargo.toml file. Addresses cloudflare#432
johnhurt
added
the
Accepted
johnhurt
pushed a commit
that referenced
this pull request
Oct 28, 2024
The current quickstart document suggests to use pingora v0.1, but it also suggests using the Opt::parse_args interface, which was introduced in release v0.3.0. Update the quickstart document to suggest using v0.3 when setting up the cargo.toml file. Addresses #432 Includes-commit: 9153a8a Replicated-from: #433
johnhurt
pushed a commit
that referenced
this pull request
Oct 28, 2024
The current quickstart document suggests to use pingora v0.1, but it also suggests using the Opt::parse_args interface, which was introduced in release v0.3.0. Update the quickstart document to suggest using v0.3 when setting up the cargo.toml file. Addresses #432 Includes-commit: 9153a8a Replicated-from: #433
Contributor
|
This has been merged as part of the weekly sync. Thank you for your contributions! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current quickstart document suggests to use pingora v0.1, but it also suggests using the Opt::parse_args interface, which was introduced in release v0.3.0. Update the quickstart document to suggest using v0.3 when setting up the cargo.toml file.
Addresses #432