Conversation
Use Changes from git blame instead.
Diff gives us final line mapping, which is what we need here.
gitlab doesn't use it anymore.
There was a problem hiding this comment.
This pull request was validated by pint.
✔️ No problems found
Stats
| Stat | Value |
|---|---|
| Version | v0.80.0-25-gc2cb012c |
| Number of rules parsed | 9 |
| Number of rules checked | 9 |
| Number of problems found | 0 |
| Number of offline checks | 0 |
| Number of online checks | 0 |
| Checks duration | 0 |
Problems
No problems reported
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
+ Coverage 99.44% 99.46% +0.02%
==========================================
Files 113 113
Lines 13752 13739 -13
==========================================
- Hits 13675 13665 -10
+ Misses 42 40 -2
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Benchmark diff: |
Get rid of dead code and default to state=noop, git_branch will override it anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop using git blame for calculating modified lines, use git diff instead.
This allows us to drop fetching of diffs from reporter APIs.