Skip to content

Add ignoreGroupMismatch to rule/dependency#1815

Merged
prymitive merged 1 commit into
mainfrom
deps
May 14, 2026
Merged

Add ignoreGroupMismatch to rule/dependency#1815
prymitive merged 1 commit into
mainfrom
deps

Conversation

@prymitive
Copy link
Copy Markdown
Collaborator

Fixes #1795.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.82.3-5-gb4578d45
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (50c1724) to head (b4578d4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1815   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines        14000     14018   +18     
=========================================
+ Hits         14000     14018   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt   │              new.txt               │
                    │   sec/op    │   sec/op     vs base               │
GlobFinder-4          20.92m ± 2%   20.80m ± 7%       ~ (p=0.393 n=10)
GitFinder-4           382.3m ± 1%   380.2m ± 1%       ~ (p=0.190 n=10)
CheckRules-4           9.629 ± 1%    9.643 ± 1%       ~ (p=0.796 n=10)
RuleIsIdentical-4     6.285m ± 0%   6.322m ± 1%  +0.58% (p=0.019 n=10)
GetChecksForEntry-4   115.4m ± 1%   116.0m ± 1%       ~ (p=0.089 n=10)
geomean               141.1m        141.1m       +0.02%

                    │    old.txt     │                new.txt                │
                    │      B/op      │     B/op      vs base                 │
GlobFinder-4          7.107Mi ± 0%     7.107Mi ± 0%       ~ (p=0.436 n=10)
GitFinder-4           15.74Mi ± 1%     15.74Mi ± 1%       ~ (p=0.853 n=10)
CheckRules-4          880.2Mi ± 0%     880.4Mi ± 0%       ~ (p=0.796 n=10)
RuleIsIdentical-4       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   56.84Mi ± 0%     56.84Mi ± 0%       ~ (p=0.324 n=10)
geomean                            ²                 +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    old.txt    │               new.txt                │
                    │   allocs/op   │  allocs/op   vs base                 │
GlobFinder-4          110.6k ± 0%     110.6k ± 0%       ~ (p=1.000 n=10)
GitFinder-4           142.9k ± 0%     142.9k ± 0%       ~ (p=0.724 n=10)
CheckRules-4          9.646M ± 0%     9.646M ± 0%       ~ (p=0.912 n=10)
RuleIsIdentical-4      0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   927.9k ± 0%     927.9k ± 0%       ~ (p=0.265 n=10)
geomean                           ²                -0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt   │            new.txt            │
        │   sec/op    │   sec/op     vs base          │
Parse-4   17.72m ± 1%   17.58m ± 1%  ~ (p=0.218 n=10)

        │   old.txt    │            new.txt             │
        │     B/op     │     B/op      vs base          │
Parse-4   6.386Mi ± 0%   6.386Mi ± 0%  ~ (p=0.342 n=10)

        │   old.txt   │            new.txt            │
        │  allocs/op  │  allocs/op   vs base          │
Parse-4   102.8k ± 0%   102.8k ± 0%  ~ (p=1.000 n=10)

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt   │            new.txt            │
               │   sec/op    │   sec/op     vs base          │
LabelsSource-4   7.752m ± 1%   7.670m ± 2%  ~ (p=0.089 n=10)

               │   old.txt    │            new.txt             │
               │     B/op     │     B/op      vs base          │
LabelsSource-4   5.700Mi ± 0%   5.704Mi ± 0%  ~ (p=0.353 n=10)

               │   old.txt   │            new.txt            │
               │  allocs/op  │  allocs/op   vs base          │
LabelsSource-4   46.76k ± 0%   46.76k ± 0%  ~ (p=0.363 n=10)

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt   │            new.txt            │
                    │   sec/op    │   sec/op     vs base          │
QueryCacheOnlySet-4   106.7n ± 1%   106.3n ± 1%  ~ (p=0.224 n=10)

                    │  old.txt   │            new.txt             │
                    │    B/op    │    B/op     vs base            │
QueryCacheOnlySet-4   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                    │  old.txt   │            new.txt             │
                    │ allocs/op  │ allocs/op   vs base            │
QueryCacheOnlySet-4   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@prymitive prymitive enabled auto-merge May 14, 2026 14:46
@prymitive prymitive merged commit 5d20e7a into main May 14, 2026
20 checks passed
@prymitive prymitive deleted the deps branch May 14, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make rule/dependency evaluation lag configurable

2 participants