lib: stricter NEW_TOKEN frame checks #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
force-pushed
the
stricter_new_token_checking
branch
from
ca37014 to
bb80141
Compare
ghedo
reviewed
Jan 15, 2024
quiche/src/lib.rs
Outdated
| return Err(Error::ProtocolViolation); | ||
| } | ||
|
|
||
| if token.is_empty() { |
Member
There was a problem hiding this comment.
This should go in the frame parsing code I think.
RFC 9000 has some low-level requirements for who is allowed to send a NEW_TOKEN frame, and what the token value can be. This change adds stricter NEW_TOKEN frame checks. It leaves any more advanced handling of the Retry mechanism as continuing TODO.
LPardue
force-pushed
the
stricter_new_token_checking
branch
from
bb80141 to
e449b91
Compare
ghedo
approved these changes
Jan 15, 2024
mgjeong
pushed a commit
to mgjeong/quiche
that referenced
this pull request
Feb 13, 2024
RFC 9000 has some low-level requirements for who is allowed to send a NEW_TOKEN frame, and what the token value can be. This change adds stricter NEW_TOKEN frame checks. It leaves any more advanced handling of the Retry mechanism as continuing TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 9000 has some low-level requirements for who is allowed to send
a NEW_TOKEN frame, and what the token value can be.
This change adds stricter NEW_TOKEN frame checks. It leaves any
more advanced handling of the Retry mechanism as continuing TODO.