qlog-dancer: improve conversion speed and disk usage and fix garbled output on Windows#2377
Open
csujedihy wants to merge 2 commits intocloudflare:masterfrom
Open
qlog-dancer: improve conversion speed and disk usage and fix garbled output on Windows#2377csujedihy wants to merge 2 commits intocloudflare:masterfrom
csujedihy wants to merge 2 commits intocloudflare:masterfrom
Conversation
1eb4a5c to
014e4c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
tabled'ssharpstyle (UTF8 unicode) is used, when being pipe'd in powershell to a text file, the box-drawing characters are misinterpreted (as ASCII). e.g.Γöé 71060.11 Γöé transport Γöé packet_received Γöé 1RTT pn=98831182, ACK {6065814, 6065815, }This PR:
sharptoascii.Some benchmarks:
Before:
After:
Time: 227s to 50s
Space: 17G to 1.3G
Preview of the new format: