tls: avoid mem::forget for borrowed handshakes#2489
Merged
Conversation
Represent temporary Handshake views over existing SSL pointers with ManuallyDrop. This keeps the ownership boundary explicit and avoids relying on mem::forget after use. Also removes one instance from tokio-quiche to allow denying mem::forget at workspace level.
LPardue
approved these changes
May 19, 2026
jannes
approved these changes
May 19, 2026
antoniovicente
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent temporary Handshake views over existing SSL pointers with ManuallyDrop. This keeps the ownership boundary explicit and avoids relying on mem::forget after use.
Also removes one instance from tokio-quiche to allow denying mem::forget at workspace level.