Conversation
LPardue
previously approved these changes
Apr 21, 2020
Merged
ghedo
requested changes
Apr 22, 2020
Member
|
I applied the nits manually since they are pretty minor. Will merge after CI is green. |
- Implemented based on RFC8312 "CUBIC for Fast Long-Distance Networks" - CUBIC is the default CC algorithm. - CUBIC specific variables is stored to cubic::State. I added this to Recovery structure itself. If you use Reno only this will be a waste of memory if you use Reno, but the overhead is small (4 fields) for now. It can be dynamically allocated later. - `f64` is used for various calculations. Optimization using integer ops is a future task. - Use libm::cbrt to avoid linking with -lm for C applications. Note that libm:cbrt is slower than C cbrt() which is asm-optimized (roughtly 2x when I test in MacOS) but the difference is small. - For config API, to use Cubic explicitly for the connection, call the following: Rust: config.set_cc_algorithm(recovery::CongestionControlAlgorithm::Cubic); C: quiche_config_set_cc_algorithm(config, QUICHE_CC_CUBIC); - `CongestionControlAlgorithm` exported as public. Also fixed the documentation. - CongestionControlOps: add collapse_cwnd()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this to Recovery structure itself. If you use Reno only
this will be a waste of memory if you use Reno, but the overhead
is small (4 fields) for now. It can be dynamically allocated later.
f64is used for various calculations. Optimization using integer ops is a future task.is slower than C cbrt() which is asm-optimized (roughtly 2x when I
test in MacOS) but the difference is small.
Rust: config.set_cc_algorithm(recovery::CongestionControlAlgorithm::Cubic);
C: quiche_config_set_cc_algorithm(config, QUICHE_CC_CUBIC);
CongestionControlAlgorithmexported as public. Also fixed the documentation.