recovery: add machinery for saving and rolling back congestion control state#893
Closed
recovery: add machinery for saving and rolling back congestion control state#893
Conversation
junhochoi
reviewed
Apr 7, 2021
| } | ||
| } | ||
|
|
||
| fn checkpoint(r: &mut Recovery) { |
Contributor
There was a problem hiding this comment.
I think we just need a stub here (remove the code in checkpoint() and rollback()) and let each PR do the actual implementation. Same to rollback()
Member
Author
There was a problem hiding this comment.
Why? This is the generic part from draft-ietf-tcpm-rfc8312bis, why would each PR re-implement the same thing?
junhochoi
reviewed
Apr 8, 2021
Comment on lines
+80
to
+102
|
|
||
| // CUBIC state checkpoint preceding the last congestion event. | ||
| prior: PriorState, | ||
| } | ||
|
|
||
| /// Stores the CUBIC state from before the last congestion event. | ||
| /// | ||
| /// <https://tools.ietf.org/id/draft-ietf-tcpm-rfc8312bis-00.html#section-4.9> | ||
| #[derive(Debug, Default)] | ||
| struct PriorState { | ||
| congestion_window: usize, | ||
|
|
||
| ssthresh: usize, | ||
|
|
||
| w_max: f64, | ||
|
|
||
| w_last_max: f64, | ||
|
|
||
| k: f64, | ||
|
|
||
| epoch_start: Option<Instant>, | ||
|
|
||
| lost_count: usize, |
Contributor
There was a problem hiding this comment.
This part can be removed too.
junhochoi
approved these changes
Apr 9, 2021
Member
Author
|
This was merged as part of #890, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply splits out the changes to save and restore CC state from #890 so e.g. it could also be used for #470.