WIP: h3: add body_capacity() helper #907
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, quiche kept all details about the relationship between stream capacity and writable DATA internal. This could lead to awkward situations where quiche would report a stream as writable, `quiche::conn::stream_capacity()` could report a non-zero value, but `send_body()` might not send anything due to DATA frame overheads. This change introduces the `quiche::h3::conn::body_capacity()` helper function to help applications determine the amount of usable capacity.
LPardue
force-pushed
the
h3-body-capacity
branch
from
95d963e to
40ae956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, quiche kept all details about the relationship between
stream capacity and writable DATA internal. This could lead to awkward
situations where quiche would report a stream as writable,
quiche::conn::stream_capacity()could report a non-zero value, butsend_body()might not send anything due to DATA frame overheads.This change introduces the
quiche::h3::conn::body_capacity()helperfunction to help applications determine the amount of usable capacity.