Version Packages #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
3ddc1dd to
7e29f60
Compare
ghostwriternr
added a commit
to ghostwriternr/sandbox-sdk
that referenced
this pull request
Nov 5, 2025
Address all minor issues identified in code review: Issue cloudflare#1: Add bucket mounting methods to ISandbox interface - Moved BucketProvider, BucketCredentials, MountBucketOptions from SDK to shared types - Added mountBucket() and unmountBucket() to ISandbox interface - Updated SDK imports to use shared types - bucket-mount/types.ts now re-exports from shared for backward compatibility Issue cloudflare#2: Fix bucket name regex for 3-character names - Changed regex from /^[a-z0-9][a-z0-9.-]{1,61}[a-z0-9]$/ to /^[a-z0-9]([a-z0-9.-]{0,61}[a-z0-9])?$/ - Previous regex was too greedy and failed on 3-char bucket names - New regex properly handles 3-63 character bucket names per S3 spec Issue cloudflare#4: Add duplicate mount path validation - Check if mountPath already exists in activeMounts before mounting - Throw InvalidMountConfigError with helpful message if duplicate detected - Prevents confusing state where same path is mounted twice All changes maintain backward compatibility and follow existing patterns.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@cloudflare/sandbox@0.0.4
Patch Changes
c0d9d33Thanks @threepointone! - actually work444d2daThanks @threepointone! - add experimental label