Normalize globstar exclude patterns for backups#645
Merged
Conversation
🦋 Changeset detectedLatest commit: 5e128ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
🐳 Docker Images Published
Usage: FROM cloudflare/sandbox:0.0.0-pr-645-5e128aeVersion: 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-645-5e128ae /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 25043096529 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-645-5e128ae cat /container-server/sandbox > sandbox && chmod +x sandbox |
scuffi
requested review from
aron-cf,
ghostwriternr and
whoiskatrin
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
whoiskatrin
approved these changes
Apr 28, 2026
Collaborator
whoiskatrin
left a comment
whoiskatrin
left a comment
There was a problem hiding this comment.
Nice 👍🏼 this was my miss, thanks for picking this up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
createBackup()excludes that use gitignore-style globstar patterns like**/node_modulesanddist/**.Previously, these patterns could make it through to the backup pipeline in a form that
mksquashfsdoes not support, which could produce empty archives. This change normalizes those exclude patterns before archive creation and applies the same behavior in both the Durable Object and container backup paths so local and production flows stay consistent.Testing