Skip to content

Conversation

@ItsWendell
Copy link
Contributor

@ItsWendell ItsWendell commented Jun 26, 2025

Summary

  • Fix baseUrl concatenation in stub forwarding to include full URL path
  • Move HttpClient initialization to constructor to properly pass stub reference
  • Ensure stub forwarding works correctly with baseUrl

Changes

  • Updated HttpClient.fetch() to use this.baseUrl + path for stub forwarding
  • Moved HttpClient initialization from class property to constructor in Sandbox class
  • Added stub: this to HttpClient options to enable proper stub forwarding

Fixes #8

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: 24f5470

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@whoiskatrin whoiskatrin self-requested a review June 27, 2025 10:26
Copy link
Collaborator

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@threepointone threepointone merged commit cbb7fcd into cloudflare:main Jun 27, 2025
1 check passed
@threepointone threepointone mentioned this pull request Jun 27, 2025
@claude claude bot mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Invalid URL: undefined/api/execute when using sandbox exec

2 participants