fix: prevent double '?' when custom apiUrl already contains query string#106
Open
unsiqasik wants to merge 1 commit into
Open
fix: prevent double '?' when custom apiUrl already contains query string#106unsiqasik wants to merge 1 commit into
unsiqasik wants to merge 1 commit into
Conversation
When custom downloadApiUrl/uploadApiUrl already contain a query string (e.g., '?token=***'), the engine was appending another '?' producing a malformed URL. Now checks for existing '?' and uses '&' as separator. Fixes cloudflare#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Summary
When
downloadApiUrloruploadApiUrlalready contain a query string (e.g.,?token=***), the engine appends its own params with a literal?separator, producing a malformed URL with two?characters.Changes
BandwidthEngine.js: Check ifapiUrlalready contains?— use&as separator if so, otherwise use?LoadNetworkEngine/index.js: Same fix for the fetch URL constructionTesting
?bytes=...)&(e.g.,?token=***&bytes=...)