feat: send bytes= query param on upload measurements#119
Closed
devandrepascoa wants to merge 3 commits into
Closed
feat: send bytes= query param on upload measurements#119devandrepascoa wants to merge 3 commits into
devandrepascoa wants to merge 3 commits into
Conversation
Uploads now include the measurement size as a bytes= query parameter (matching the download direction). The POST body is already exactly numBytes, so this lets the server bound/measure upload volume from the URL without relying on Content-Length (e.g. for streamed/chunked clients or edge WAF rules).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the upload size signal needed by the speed.cloudflare.com server cap.
bytes=<size>, matching download requests.cf-meta-upload-byteswhen the server returns it, so capped uploads log the server-accepted byte count instead of the client-requested size.No user-visible behavior change for normal clients:
bytes=matches the upload body size. If the server caps an over-sized upload, the log payload reflects the capped byte count.