Telescopetest-io: Improve metrics tab display and clean up bloated components #178
Merged
sergeychernyshev merged 16 commits intocloudflare:mainfrom Mar 12, 2026
Merged
Telescopetest-io: Improve metrics tab display and clean up bloated components #178sergeychernyshev merged 16 commits intocloudflare:mainfrom
sergeychernyshev merged 16 commits intocloudflare:mainfrom
Conversation
15ed284 to
c858821
Compare
Member
sergeychernyshev
left a comment
There was a problem hiding this comment.
We did discuss a few changes off-line. Let me know when you have those ready and we can merge.
…le allmetrics.astro component like waterfall and resources
… bar segment, set default filter select to just ttfb, changed filter select UI
…ntloadedeventstart)
sergeychernyshev
requested changes
Mar 10, 2026
Member
sergeychernyshev
left a comment
There was a problem hiding this comment.
More changes, unfortunately - see comments inline.
I also could not find where it is, but I can't see loadEventStart on the chart - it is listed in the timestamps, but when I hover over it, nothing is highlighted.
…, made dcl filters only show timing labels. added some changes to ttio.md
Member
Member
sergeychernyshev
approved these changes
Mar 12, 2026
Member
sergeychernyshev
left a comment
There was a problem hiding this comment.
I believe we're good to go for this second pass with a fun diagram!
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



AllMetrics.astro, a component used as a Tab under telescopetest.io/results/[testId]. This calls on the helper functions inlib/allmetrics/Also did a lot of file/naming cleanup, which made this PR kind of ugly:
Summary.astrocomponent toMetricCard.astroMetricSection.astrocomponent toSection.astrolib/types/results.tstolib/types/metrics.ts, now this file is just for metricsAdditional things to add in future:
Closes #191