refactor(routing): dedupe findFileWithExtensions helper

[james-elicx]

Summary

• Extract the matcher.dottedExtensions.some((ext) => existsSync(basePath + ext)) one-liner into a single shared helper in routing/file-matcher.ts.
• Replace the two identical local copies in build/prerender.ts and server/dev-server.ts with the shared export.
• Pure refactor: same return type, same semantics. Follow-up to refactor(routing): dedupe param decoding into shared helper #1058.

Files changed

• packages/vinext/src/routing/file-matcher.ts — add findFileWithExtensions export (+ existsSync import).
• packages/vinext/src/build/prerender.ts — drop local helper, import shared one.
• packages/vinext/src/server/dev-server.ts — drop local helper, import shared one. Removed now-unused import fs from "node:fs".

Test plan

• pnpm vp test run tests/app-router.test.ts tests/pages-router.test.ts (508 tests pass)
• pnpm fmt --write on touched files
• pnpm knip (clean)

🤖 Generated with Claude Code

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@1076

commit: db6277c

[github-actions]

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original

[james-elicx]

/bigbonk review

[ask-bonk]

Clean dedupe. Reviewed all three files:

• file-matcher.ts: New findFileWithExtensions is a standalone pure function next to the ValidFileMatcher type it consumes — good home for it. The existsSync import is the only new side-effect import; file-matcher.ts already imports from node:fs/promises, so adding node:fs is fine.

• prerender.ts: Drops the local copy and the now-unnecessary type ValidFileMatcher import (the type flows through createValidFileMatcher's return type). fs default import is retained — still used in 14 call sites for mkdirSync/writeFileSync.

• dev-server.ts: Drops both the local copy and the import fs from "node:fs" that was only there to support it. Confirmed fs. has zero remaining references in the file.

No semantic change, no new call sites introduced. LGTM.

[ask-bonk]

Approved PR #1076. The refactor is clean — both local copies of findFileWithExtensions are replaced by a single shared export in routing/file-matcher.ts, and the now-unused import fs from "node:fs" in dev-server.ts is correctly removed (no remaining fs. references). No semantic changes.

github run